[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pixman: fix warning
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] pixman: fix warning |
|
Date: |
Fri, 04 Jan 2013 16:47:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
Hi,
>> +/* pixman-0.16.0 headers have a redundant declaration */
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wredundant-decls"
>> #include <pixman.h>
>> +#pragma GCC diagnostic pop
>
> IIRC we can't rely on gcc knowing about 'diagnostic push/pop' --
> eg in coroutine-ucontext.c we avoid using that for this reason.
Indeed, even '#pragma GCC diagnostic' isn't reliable.
/me goes grab stuff from coroutine-ucontext.c and run that through bunch
of testbuilds ...
cheers,
Gerd