[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, wit
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support |
Date: |
Thu, 10 Jan 2013 11:40:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> Add chardev-add and chardev-remove qmp commands. Hotplugging
> a null chardev is supported for now, more will be added later.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> +
> +##
> +# @ChardevReturn:
> +#
> +# Return infos about the chardev backend just created.
s/infos/info/ or maybe s/infos/details/
> +ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
> + Error **errp)
> +{
> + ChardevReturn *ret = g_new0(ChardevReturn, 1);
> + CharDriverState *chr = NULL;
> +
Should you add:
chr = qemu_chr_find(id);
if (chr) {
error_setg(errp, "Chardev '%s' already exists", id);
return NULL;
}
> + switch (backend->kind) {
> + case CHARDEV_BACKEND_KIND_NULL:
> + chr = qemu_chr_open_null(NULL);
> + break;
> + default:
> + error_setg(errp, "unknown chardev backend (%d)", backend->kind);
> + break;
> + }
> +
> + if (chr == NULL && !error_is_set(errp)) {
> + error_setg(errp, "Failed to create chardev");
> + }
> + if (chr) {
> + chr->label = g_strdup(id);
> + chr->avail_connections = 1;
> + QTAILQ_INSERT_TAIL(&chardevs, chr, next);
> + }
> + return ret;
Do you really want to be returning a successful object even when the
error is set, or should you start with ret = NULL, and only do the
g_new0(ChardevReturn, 1) on success?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 01/10] chardev: add error reporting for qemu_chr_new_from_opts, (continued)
- [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/10
- Re: [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support,
Eric Blake <=
- [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10