qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp)
Date: Thu, 10 Jan 2013 12:41:43 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> Also alias the old parport name to parallel for -chardev.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  qapi-schema.json |    3 ++-
>  qemu-char.c      |   44 ++++++++++++++++++++++++++++----------------
>  qemu-options.hx  |    5 ++++-
>  3 files changed, 34 insertions(+), 18 deletions(-)
> 

>  ##
> -{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] }
> +{ 'enum': 'ChardevPortKind', 'data': [ 'serial',
> +                                       'parallel' ] }
>  
>  { 'type': 'ChardevPort', 'data': { 'device' : 'str',
>                                     'type'   : 'ChardevPortKind'} }

In patch 7, should the enum and type have separate documentation?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]