[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appro
|
From: |
Meador Inge |
|
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal |
|
Date: |
Thu, 10 Jan 2013 16:27:41 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 |
On 01/10/2013 04:12 PM, Peter Maydell wrote:
> This is an OS/ABI specific define, right? I don't think it
> belongs in the target-mips header file. Since it only has one
> user, I think you could reasonably just put it in linux-user/main.c.
The enum will only be used in the MIPS CPU loop. I originally put it in
target-mips/cpu.h because that is where the exception codes
are defined. However, the one user argument makes sense to me. I
moved the enum definition.
Thanks for the review.
--
Meador Inge
CodeSourcery / Mentor Embedded