qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/8] qemu-ga: ga_open_pidfile(): use qemu_open()


From: Michael Roth
Subject: [Qemu-devel] [PATCH 1/8] qemu-ga: ga_open_pidfile(): use qemu_open()
Date: Mon, 14 Jan 2013 13:55:05 -0600

From: Luiz Capitulino <address@hidden>

This ensures that O_CLOEXEC is passed to open(), this way the
pid file fd is not leaked to executed processes.

Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Acked-by: Amos Kong <address@hidden>
Tested-by: Amos Kong <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
 qga/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index a9b968c..4239150 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -267,7 +267,7 @@ static bool ga_open_pidfile(const char *pidfile)
     int pidfd;
     char pidstr[32];
 
-    pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
+    pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
     if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) {
         g_critical("Cannot lock pid file, %s", strerror(errno));
         if (pidfd != -1) {
-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]