qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting
Date: Fri, 25 Jan 2013 11:25:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

Il 25/01/2013 10:21, Andreas Färber ha scritto:
>> > 
>> > Ping.
> I believe I was still waiting for an explanation why this qbus_init()
> function must be exposed rather than one _new() and one _initialize()
> function... Not getting feedback on that, I was already considering
> sending you an alternative patch for the initial two.

Because you cannot object_initialize the result of object_new.  It would
overwrite the free callback and leak memory.

So you need three functions: _new() (which is usually called foo_create
for buses), _initialize() (which is usually foo_create_inplace), and a
third which I called _init().

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]