Re: [Qemu-devel] [PATCH for-1.4 10/12] qemu-char: General chardev "memory" code cleanup

[Eric Blake]

On 02/05/2013 09:22 AM, Markus Armbruster wrote:
> Inline trivial cirmem_chr_is_empty() into its only caller.
> 
> Rename qemu_chr_cirmem_count() to cirmem_count().
> 
> Fast ring buffer index wraparound.  Without this, there's no point in
> restricting size to a power two.
> 
> qemu_is_chr(chr, "memory") returns *zero* when chr is a memory
> character device, which isn't what I'd expect.  Replace it by the
> saner and more obviously correct chr_is_cirmem().  Also avoids
> encouraging testing for specific character devices elsewhere.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qemu-char.c | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature