Re: [Qemu-devel] [PATCH v1 3/6] arm: *mpcore.c: CamelCased type names

[Peter Crosthwaite]

On Tue, Feb 19, 2013 at 4:16 AM, Peter Maydell <address@hidden> wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> <address@hidden> wrote:
>> --- a/hw/arm11mpcore.c
>> +++ b/hw/arm11mpcore.c
>> @@ -12,7 +12,7 @@
>>
>>  /* MPCore private memory region.  */
>>
>> -typedef struct mpcore_priv_state {
>> +typedef struct MPCorePrivState {
>>      SysBusDevice busdev;
>>      uint32_t scu_control;
>>      int iomemtype;
>> @@ -23,14 +23,14 @@ typedef struct mpcore_priv_state {
>>      DeviceState *mptimer;
>>      DeviceState *gic;
>>      uint32_t num_irq;
>> -} mpcore_priv_state;
>> +} MPCorePrivState;
>
> ARM11MPCorePrivState, please (matches the QOM device
> name). This was only missing the core name in the
> struct type name because it was the first one implemented
> and never got renamed, but if we're doing a rename of
> the type anyway we might as well bring it in line with
> the others.
>

Fixed,

Regards,
Peter

> thanks
> -- PMM
>