Re: [Qemu-devel] [PATCH 1/9] build: disable Wstrict-prototypes

[Andreas Färber]

Am 20.02.2013 15:27, schrieb Peter Maydell:
> On 20 February 2013 13:43, Anthony Liguori <address@hidden> wrote:
>> GTK won't build with strict-prototypes due to gtkitemfactory.h:
>>
>>     /* We use () here to mean unspecified arguments. This is deprecated
>>      * as of C99, but we can't change it without breaking compatibility.
>>      * (Note that if we are included from a C++ program () will mean
>>      * (void) so an explicit cast will be needed.)
>>      */
>>     typedef     void    (*GtkItemFactoryCallback)  ();
> 
> Yuck. Consider wrapping the use of this header with gcc diagnostic
> pragmas instead so we don't have to drop a perfectly good warning
> flag for the sake of busted libraries?

+1, same thought here. Would GCC diagnostics work for clang though?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg