[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] require gtk 2.20+
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] require gtk 2.20+ |
|
Date: |
Fri, 22 Feb 2013 11:17:00 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 22, 2013 at 12:11:58PM +0100, Gerd Hoffmann wrote:
> The gtk code uses gtk_widget_get_realized which is available in 2.20+
> only, so make this the minimum accepted versions. Fixes build failures
> on RHEL-6 (which ships 2.18) by not building gtk support there.
IMHO it'd be nicer to add the compat code to let it build with
something like this:
#if !GTK_CHECK_VERSION(2, 18, 0)
#define gtk_widget_get_realized(w) GTK_WIDGET_REALIZED(w)
#endif
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|