[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands
From: |
Dietmar Maurer |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands |
Date: |
Thu, 28 Feb 2013 10:01:02 +0000 |
> > You can easily extend the API to allow multiple backups (In a fully
> > backwards compatible way). So there is no need to change that now.
>
> I disagree.
>
> You propose something like:
>
> 1. -> { "execute": "backup",
> "arguments": { "backup-file": "foo.vma" } }
> <- { "return": { "deb8e5da-5b69-46d1-86c6-1b715a22809f" } }
>
> This *deletes* any prior BackupStatus. Clearly inappropriate with
> multiple backups. How exactly do you propose to extend it in a
> backwards compatible way?
It currently deletes the BackupStatus. But this is related to the current
implementation, not the API definition.
> 2. -> { "execute": "query-backup" }
>
> This is specified to return exactly one BackupStatus.
>
> How exactly do you propose to extend it for multiple backups?
Add an optional 'uuid' parameter. We can auto-select the job if there is only
one job running
> 3. -> { "execute": "backup-cancel" }
>
> This is specified to cancel "the current execute backup process".
>
> This becomes *ill-defined* when multiple backup processes are
> executing.
Again, we can add an optional 'uuid' parameter.
- [Qemu-devel] [PATCH v5 0/6] Efficient VM backup for qemu, Dietmar Maurer, 2013/02/21
- [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Dietmar Maurer, 2013/02/21
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Markus Armbruster, 2013/02/27
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Eric Blake, 2013/02/27
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Dietmar Maurer, 2013/02/27
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Markus Armbruster, 2013/02/28
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands,
Dietmar Maurer <=
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Markus Armbruster, 2013/02/28
- Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands, Dietmar Maurer, 2013/02/28
[Qemu-devel] [PATCH v5 1/6] add documenation for new backup framework, Dietmar Maurer, 2013/02/21
[Qemu-devel] [PATCH v5 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
[Qemu-devel] [PATCH v5 5/6] add regression tests for backup, Dietmar Maurer, 2013/02/21
[Qemu-devel] [PATCH v5 6/6] add vm state to backups, Dietmar Maurer, 2013/02/21