qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands


From: Dietmar Maurer
Subject: Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands
Date: Thu, 28 Feb 2013 12:43:25 +0000

> >>     With multiple backup support, we still need to keep it working
> >>     unchanged when no or just one backup is executing.  When more are
> >>     executing, we have to make it fail, unless an optional argument is
> >>     given.
> 
> Again, unnecessary complexity.
> 
> Moreover, omitting the "optional" argument will break hard unless you control
> all monitors.  Because if you don't, you never know whether there's another
> backup in flight.
> 
> Evolution of APIs occasionally gets us "optional" parameters that are really
> mandatory.  Tolerable.  But when a little foresight lets us avoid such warts, 
> we
> should.

OK, will try to fix that.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]