[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to bl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c |
Date: |
Fri, 08 Mar 2013 13:27:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/06/2013 11:07 PM, Wenchao Xia wrote:
> This patch also fix small code style error reported by check script.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/snapshot.c | 23 +++++++++++++++++++++++
> include/block/snapshot.h | 9 +++++++++
> savevm.c | 23 +----------------------
> 3 files changed, 33 insertions(+), 22 deletions(-)
>
> +++ b/include/block/snapshot.h
> @@ -1,4 +1,13 @@
> #ifndef SNAPSHOT_H
> #define SNAPSHOT_H
>
> +#include "qemu-common.h"
> +/*
> + * block.h is needed for QEMUSnapshotInfo, it can be removed when define is
> + * moved here.
> + */
> +#include "block.h"
Why not move QEMUSnapshotInfo here as part of this patch, and/or reorder
the series to do the code motion of that type before you move the function?
That said, this looks like an accurate code motion patch. But see my
comments earlier in the series about merging this with 1/20.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 02/20] build: add block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c, Wenchao Xia, 2013/03/07
- Re: [Qemu-devel] [PATCH V8 03/20] block: move bdrv_snapshot_find() to block/snapshot.c,
Eric Blake <=
- [Qemu-devel] [PATCH V8 04/20] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 07/20] block: add snapshot info query function bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/07