[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and co
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c |
Date: |
Tue, 12 Mar 2013 13:41:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/11/2013 05:23 AM, Wenchao Xia wrote:
> This patch adds block/qapi.c and moves the functions there. To avoid
> conflict and tip better, macro in header file is BLOCK_QAPI_H instead
> of QAPI_H. The moving is for making review easier, those functions
> will be modified and renamed later.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/Makefile.objs | 2 +-
> block/qapi.c | 96
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> include/block/qapi.h | 24 ++++++++++++
> qemu-img.c | 86 ++-------------------------------------------
> 4 files changed, 124 insertions(+), 84 deletions(-)
> create mode 100644 block/qapi.c
> create mode 100644 include/block/qapi.h
>
> +++ b/block/qapi.c
> @@ -0,0 +1,96 @@
> +/*
> + * Block layer qmp related functions
> + *
> + * Copyright IBM, Corp. 2013
> + *
> + * Authors:
> + * Wenchao Xia <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU LGPL, version 2 or later.
> + * See the COPYING.LIB file in the top-level directory.
This is another case of moving code from a BSD file into an LGPLv2+
file; depending on what the resolution is for 1/14, you should do the
same thing here.
Everything else looks okay, but I'm reluctant to add reviewed-by without
the license issue sorted.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V9 03/14] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 05/14] block: add snapshot info query function bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/11
- Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c,
Eric Blake <=
[Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 02/14] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 09/14] qmp: add interface query-images, Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 07/14] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 10/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 08/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/11