Re: [Qemu-devel] migrate cancel bug in latest qemu upstream

[Amos Kong]

On Mon, Mar 18, 2013 at 09:20:03PM +0800, Amos Kong wrote:
> On Tue, Mar 12, 2013 at 10:58:54AM +0800, Amos Kong wrote:
> > Hi quintela, I found a migrate bug in Autotest result, not sure if
> > it's already known.
> > 
> > | commit fa3889162ff724d09eb6b6bd06ba54769100a77f
> > | Merge: 6e72a00 a4960ef
> > | Author: Anthony Liguori <address@hidden>
> > | Date:   Sun Mar 10 20:39:17 2013 -0500
> > 
> 
> Bug was introduced between v1.1.0..v1.2.0
> 
> ----
> 
> This bug could not be reproduced in current latest qemu.git
> 
> | commit 225dc991b03f0f034aa348f5cf499de9d0979107
> | Author: Cornelia Huck <address@hidden>
> | Date:   Fri Mar 15 10:57:40 2013 +0100
> | 
> |     s390: Fix cpu refactoring fallout.
> | 


This bug was already fixed by this patch:

commit dba433c03a0f5dc22a459435dd89557886298921
Author: Paolo Bonzini <address@hidden>
Date:   Fri Feb 22 17:36:17 2013 +0100

    migration: simplify error handling
    
    Always use qemu_file_get_error to detect errors, since that is how
    QEMUFile itself drops I/O after an error occurs.  There is no need
    to propagate and check return values all the time.
    
    Also remove the "complete" member, since we know that it is set (via
    migrate_fd_cleanup) only when the state changes.
    
    Reviewed-by: Orit Wasserman <address@hidden>
    Reviewed-by: Juan Quintela <address@hidden>
    Signed-off-by: Paolo Bonzini <address@hidden>
    Signed-off-by: Juan Quintela <address@hidden>