Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename

[Kevin Wolf]

Am 20.03.2013 um 03:14 hat Eric Blake geschrieben:
> On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> > In order to achieve this, the .bdrv_probe callbacks of all drivers must
> > cope with this. The DMG driver is the only one that bases its decision
> > on the filename and it needs to be changed.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block/dmg.c | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> > 
> > diff --git a/block/dmg.c b/block/dmg.c
> > index c1066df..3141cb5 100644
> > --- a/block/dmg.c
> > +++ b/block/dmg.c
> > @@ -51,9 +51,16 @@ typedef struct BDRVDMGState {
> >  
> >  static int dmg_probe(const uint8_t *buf, int buf_size, const char 
> > *filename)
> >  {
> > -    int len=strlen(filename);
> > -    if(len>4 && !strcmp(filename+len-4,".dmg"))
> 
> Someone really didn't like whitespace :)  Glad to see it rewritten to
> keep the patch checker happy.

Actually I don't think it would have complained, because it would be
context only. But I simply can't leave this code alone while touching
the function. :-)

Kevin