Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing

[Kevin Wolf]

Am 20.03.2013 um 03:07 hat Eric Blake geschrieben:
> On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> > bdrv_open() uses two different variables called options. Rename one of
> > them to avoid confusion and to allow the outer one to be accessed
> > everywhere.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block.c | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> Should configure be setting up -Wshadow to help prevent instances like this?

Perhaps it should. But I tried it out and there are by far too many
warnings, so that doing this patch wouldn't be a trivial task.

Kevin