Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block

[Kevin Wolf]

Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben:
>   With these parameters, user can choose the information to be showed,
> to avoid message flood in the montior.
> 
> Signed-off-by: Wenchao Xia <address@hidden>

Aha, so here you actually introduce the 'device' parameter. If you can
have this patch first, and only then patch 16, then limiting the new
output to the form with a device specified should be trivial.

> --- a/monitor.c
> +++ b/monitor.c
> @@ -2455,9 +2455,10 @@ static mon_cmd_t info_cmds[] = {
>      },
>      {
>          .name       = "block",
> -        .args_type  = "",
> -        .params     = "",
> -        .help       = "show the block devices",
> +        .args_type  = "backing:-b,device:B?",
> +        .params     = "[-b] [device]",
> +        .help       = "show info of one block device or all block devices "
> +                      "[and info of backing images with -b option",

That '[' doesn't look intentional?

Kevin