|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint |
Date: | Thu, 04 Apr 2013 16:04:07 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 04/04/2013 15:56, Peter Maydell ha scritto: >> > #define TARGET_LONG_BITS 32 >> > +#define ABI_INT_ALIGNMENT 2 >> > >> > #define CPUArchState struct CPUM68KState > I think this define should go in an include file in > linux-user/m68k/ -- it's ABI specific and we should > be aiming to isolate ABI specific info in linux-user/ > rather than having it leaking into target-* and thus > into the system emulation code. > > Otherwise patch looks good. That would create 10 empty files, and two files between one and three lines of code. I would just put those in include/exec/user/abitypes.h. WDYT? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |