[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v18 5/7] pvpanic: add document of pvpanic
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v18 5/7] pvpanic: add document of pvpanic |
Date: |
Thu, 11 Apr 2013 10:52:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Hu Tao <address@hidden> writes:
> Signed-off-by: Hu Tao <address@hidden>
> ---
> docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 docs/specs/pvpanic.txt
>
> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
> new file mode 100644
> index 0000000..d72d667
> --- /dev/null
> +++ b/docs/specs/pvpanic.txt
> @@ -0,0 +1,37 @@
> +PVPANIC DEVICE
> +==============
> +
> +pvpanic device is a simulated ISA device, through which a guest panic
> +event is sent to qemu, and a QMP event is generated. This allows
> +management apps (e.g. libvirt) to be notified and respond to the event.
> +
> +The management app has the option of waiting for GUEST_PANICKED events,
> +and/or polling for guest-panicked RunState, to learn when the pvpanic
> +device has fired a panic event.
> +
> +ISA Interface
> +-------------
> +
> +pvpanic uses port 0x505 to receive a panic event from the guest. On
> +write, bit 0 is set to indicate guest panic has happened. On read, bit
> +0 is set to indicate guest panic notification is supported. Remaining
> +bits are reserved, and should be written as 0, and ignored on read.
> +
> +ACPI Interface
> +--------------
> +
> +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods:
> +
> +RDPT: To determine whether guest panic notification is supported.
> +Arguments: None
> +Return: Returns a byte, bit 0 set to indicate guest panic
> + notification is supported. Other bits are reserved and
> + should be ignored.
> +
> +WRPT: To send a guest panic event
> +Arguments: Arg0 is a byte, with bit 0 set to indicate guest panic has
> + happened. Other bits are reserved and should be cleared.
> +Return: None
> +
> +The ACPI device will automatically refer to the right port in case it
> +is modified.
Here, you implicitly state that the port is configurable. Section "ISA
Interface" sounds like it was fixed to 0x505. It's actually
configurable. Rephrase it a bit there? See my reply to 3/7 for a
possible wording.
- [Qemu-devel] [PATCH v18 0/7] Add pvpanic device to deal with guest panic event, Hu Tao, 2013/04/09
- [Qemu-devel] [PATCH v18 4/7] pvpanic: pass configurable ioport to seabios, Hu Tao, 2013/04/09
- [Qemu-devel] [PATCH v18 5/7] pvpanic: add document of pvpanic, Hu Tao, 2013/04/09
- Re: [Qemu-devel] [PATCH v18 5/7] pvpanic: add document of pvpanic,
Markus Armbruster <=
- [Qemu-devel] [PATCH v18 1/7] add a new runstate: RUN_STATE_GUEST_PANICKED, Hu Tao, 2013/04/09
- [Qemu-devel] [PATCH v18 7/7] Wire up disabled wait a panicked event on s390, Hu Tao, 2013/04/09
- [Qemu-devel] [PATCH v18 6/7] pvpanic: create pvpanic by default for machine 1.5, Hu Tao, 2013/04/09
- Re: [Qemu-devel] [PATCH v18 0/7] Add pvpanic device to deal with guest panic event, Paolo Bonzini, 2013/04/10