Re: [Qemu-devel] [PATCH] target-i386: Do not allow to set apic-id one CPU is realized

[Andreas Färber]

Am 26.04.2013 19:29, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  target-i386/cpu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f1cecc0..3152ad5 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1289,6 +1289,12 @@ static void x86_cpuid_set_apic_id(Object *obj, Visitor 
> *v, void *opaque,
>      Error *error = NULL;
>      int64_t value;
>  
> +    if (DEVICE(obj)->realized) {

http://wiki.qemu.org/QOMConventions

Anthony asked to not do FOO(x)->bar. Please add a DeviceState *dev
variable above.

> +        error_setg(errp, "Attempt to set property '%s' on '%s' after "
> +                   "it was realized", name, object_get_typename(obj));

Peter had introduced a helper for that that you had pointed me to
before, but I believe it's static in qdev-properties.c, so copying seems
the easiest here. Fine with me if you could address the above.

Andreas

> +        return;
> +    }
> +
>      visit_type_int(v, &value, name, &error);
>      if (error) {
>          error_propagate(errp, error);
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg