[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command |
Date: |
Fri, 26 Apr 2013 16:58:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote:
> @block-backup
>
> Start a point-in-time copy of a block device to a new destination.
>
> @device: the name of the device whose writes should be mirrored.
>
> @target: the target of the new image. If the file exists, or if it
> is a device, the existing file/device will be used as the new
> destination. If it does not exist, a new file will be created.
>
> @format: #optional the format of the new destination, default is to
> probe if @mode is 'existing', else the format of the source
>
> @mode: #optional whether and how QEMU should create a new image, default is
> 'absolute-paths'.
>
> @speed: #optional the maximum speed, in bytes per second
>
> Returns: nothing on success
> If @device is not a valid block device, DeviceNotFound
This starts a new block job type; I assume the existing block-job-cancel
and query-block-jobs can track it.
I'd really love to see us change 'BlockJobInfo' to use an enum for
'type', instead of its open-coded 'str'. Likewise, the block-job
related events in QMP/qmp-events.txt should be updated to refer to the
enum instead of also being open-coded 'str'. Will this job be called
"backup"?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Eric Blake, 2013/04/23
Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Wenchao Xia, 2013/04/27