[Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())

[Michael S. Tsirkin]

Anthony, can we please make it a rule that
all patches in pull request are tagged specially?

As it is, patchwork is full of patches that were already reviewed and
merged, all my scripts that were filtering and sorting patches are also
useless, and I get to wade through each patch for the second time.

Maybe you could teach your scripts to ignore [PULL X/Y] where X>0?

This way people could tag all resent patches
as PULL.

Further,
PULL 0/2
PULL 1/2
PULL 2/2

aligns better than

PULL 0/2
PATCH 1/2
PATCH 2/2



On Thu, May 02, 2013 at 03:35:34PM +0200, Andreas Färber wrote:
> From: "Michael S. Tsirkin" <address@hidden>
> 
> Wrapper to avoid open-coded loops and to make CPUState iteration
> independent of CPUArchState.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  exec.c            | 10 ++++++++++
>  include/qom/cpu.h |  9 +++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/exec.c b/exec.c
> index fa1e0c3..19725db 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -265,6 +265,16 @@ CPUState *qemu_get_cpu(int index)
>      return env ? cpu : NULL;
>  }
>  
> +void qemu_for_each_cpu(void (*func)(CPUState *cpu, void *data), void *data)
> +{
> +    CPUArchState *env = first_cpu;
> +
> +    while (env) {
> +        func(ENV_GET_CPU(env), data);
> +        env = env->next_cpu;
> +    }
> +}
> +
>  void cpu_exec_init(CPUArchState *env)
>  {
>      CPUState *cpu = ENV_GET_CPU(env);
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 1b4de17..a28e5ff 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -216,6 +216,15 @@ bool cpu_is_stopped(CPUState *cpu);
>  void run_on_cpu(CPUState *cpu, void (*func)(void *data), void *data);
>  
>  /**
> + * qemu_for_each_cpu:
> + * @func: The function to be executed.
> + * @data: Data to pass to the function.
> + *
> + * Executes @func for each CPU.
> + */
> +void qemu_for_each_cpu(void (*func)(CPUState *cpu, void *data), void *data);
> +
> +/**
>   * qemu_get_cpu:
>   * @index: The address@hidden value of the CPU to obtain.
>   *
> -- 
> 1.8.1.4