Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

[Eduardo Habkost]

On Wed, May 08, 2013 at 01:43:22PM +0800, li guang wrote:
> ping ...

I guess this didn't get any attention because we were already past soft
freeze, and the focus was to get important features/fixes in shape
before hard freeze.

I don't think I can review it because I never worked on the TCG code.
But I have one question below:


> 
> 在 2013-04-23二的 16:16 +0800，liguang写道：
> > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF
> > as suggested by Richard Henderson <address@hidden>
> > 
> > Li Guang (12)
> >      target-i386/helper: remove EAX macro
> >      target-i386/helper: remove EBX macro
> >      target-i386/helper: remove ECX macro
> >      target-i386/helper: remove EDX macro
> >      target-i386/helper: remove EBP macro
> >      target-i386/helper: remove ESP macro
> >      target-i386/helper: remove ESI macro
> >      target-i386/helper: remove EDI macro
> >      target-i386/helper: remove EIP macro
> >      target-i386/helper: remove DF macro

What about CC_DST, CC_SRC, CC_SRC2, CC_OP?

> >      target-i386/helper: remove redundant env->eip assignment
> >      target-i386: fix over 80 chars warnings
> > 
> > cpu-exec.c                |   4 ++--
> > target-i386/cc_helper.c   |   2 +-
> > target-i386/cpu.h         |  24 -
> > target-i386/excp_helper.c |   2 +-
> > target-i386/int_helper.c  |  86 ++++++++++++++++++++++----------------------
> > target-i386/mem_helper.c  |  24 +++---
> > target-i386/misc_helper.c | 107 +++---
> > target-i386/seg_helper.c  | 182 +++---
> > target-i386/smm_helper.c  |  64 +++---
> > target-i386/svm_helper.c  |  66 ++++++++--------
> > 10 files changed, 280 insertions(+), 281 deletions(-)
> > 
> 
> 
> 

-- 
Eduardo