[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route |
Date: |
Fri, 21 Jun 2013 22:03:01 +1000 |
On Fri, 2013-06-21 at 12:33 +0200, Alexander Graf wrote:
> > +int kvm_arch_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
> > +{
> > + if (!kvm_msi_via_irqfd_allowed)
> > + return -1;
> > +
> > + msg.address -= spapr->msi_win_addr;
> > + return (msg.address >> 2) + msg.data;
>
> This breaks BookE.
It might be a bit more constructive to explain why and maybe propose a
solution... Alexey doesn't necessarily know the specifics of the BookE
stuff :-)
Cheers,
Ben.
[Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alexey Kardashevskiy, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alexander Graf, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route,
Benjamin Herrenschmidt <=
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alexander Graf, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Benjamin Herrenschmidt, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alexander Graf, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Benjamin Herrenschmidt, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alexander Graf, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Benjamin Herrenschmidt, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Alex Williamson, 2013/06/21
- Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route, Benjamin Herrenschmidt, 2013/06/21
[Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd, Alexey Kardashevskiy, 2013/06/21