[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change DisasCon
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change DisasContext::env to CPUState |
|
Date: |
Mon, 01 Jul 2013 10:23:08 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 06/29/2013 01:01 PM, Andreas Färber wrote:
> - CPUAlphaState *env;
> + AlphaCPU *cpu;
Actually, I take this back. I'd prefer that we simply pull out the two
variables that we need and place them in the DisasContext. That's the way it
should have been in the first place.
> @@ -3394,7 +3394,7 @@ static inline void
> gen_intermediate_code_internal(AlphaCPU *cpu,
> gen_opc_end = tcg_ctx.gen_opc_buf + OPC_MAX_SIZE;
>
> ctx.tb = tb;
> - ctx.env = env;
> + ctx.cpu = alpha_env_get_cpu(env);
This should have been ctx.cpu = cpu anyway, apparently fixed in the next patch.
r~