[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report() |
Date: |
Tue, 02 Jul 2013 08:47:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7 |
On 07/01/13 20:54, Seiji Aguchi wrote:
> [Issue]
> When we offer a customer support service and a problem happens
> in a customer's system, we try to understand the problem by
> comparing what the customer reports with message logs of the
> customer's system.
>
> In this case, we often need to know when the problem happens.
>
> But, currently, there is no timestamp in qemu's error messages.
> Therefore, we may not be able to understand the problem based on
> error messages.
>
> [Solution]
> Add a timestamp to qemu's error message logged by
> error_report() with g_time_val_to_iso8601().
>
> Signed-off-by: Seiji Aguchi <address@hidden>
> ---
> Changelog
> v4 -> v5
> - Use sizeof() to define TIMESTAMP_LEN.
> - Fix descriptions of msg option.
> - Rename TIME_H to QEMU_TIME_H. (avoiding double inclusion of qemu/time.h)
> - Change argument of qemu_get_timestamp_str to "char *" and "size_t".
> - Confirmed msg option is displayed by query-command-line-options.
Reviewed-by: Laszlo Ersek <address@hidden>
Since you plan to post followup patches, please at that time include a
one-liner modification: the STEXI-ETEXI section in "qemu-options.hx"
still says (right before ETEXI) "(disabled by default)". I think it
should be fixed in a followup, not by posting v6.
Thanks!
Laszlo