[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] linux-user: Add is_write segfault check for
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] linux-user: Add is_write segfault check for ARM hosts |
Date: |
Sat, 6 Jul 2013 11:24:39 +0100 |
On 6 July 2013 01:36, Alexander Graf <address@hidden> wrote:
> When we get a segmentation fault we check whether the fault was a write. If
> it was a write, it might be a fault because we tried to modify a code region.
>
> This logic does not work on ARM hosts, because they don't evaluate whether a
> segementation fault is due to a write. Instead they always declare it a read.
>
> So self modifying code fails with a segmentation fault whenever it tries to
> modify itself.
>
> Add the is_write evaluation based on what the kernel tells us as fault reason.
>
> Signed-off-by: Alexander Graf <address@hidden>
We've already got a patch for this on list :
http://patchwork.ozlabs.org/patch/248590/
thanks
-- PMM
[Qemu-devel] [PATCH 8/9] linux-user: Default to 64k guest base, Alexander Graf, 2013/07/05