[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page() |
Date: |
Fri, 12 Jul 2013 11:09:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/12/2013 08:40 AM, address@hidden wrote:
> From: "Michael R. Hines" <address@hidden>
>
> We were not checking for a valid 'bytes_sent' pointer before accessing it.
>
> Signed-off-by: Michael R. Hines <address@hidden>
> ---
> savevm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/savevm.c b/savevm.c
> index e0491e7..03fc4d9 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -662,7 +662,7 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t
> block_offset,
> offset, size, bytes_sent);
>
> if (ret != RAM_SAVE_CONTROL_DELAYED) {
> - if (*bytes_sent > 0) {
> + if (bytes_sent && *bytes_sent > 0) {
> qemu_update_position(f, *bytes_sent);
> } else if (ret < 0) {
> qemu_file_set_error(f, ret);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 resend/cleanup 0/8] rdma: core logic, mrhines, 2013/07/12
- [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page(), mrhines, 2013/07/12
- Re: [Qemu-devel] [PATCH v3 resend/cleanup 2/8] rdma: bugfix: ram_control_save_page(),
Eric Blake <=
- [Qemu-devel] [PATCH v3 resend/cleanup 4/8] rdma: core logic, mrhines, 2013/07/12
- [Qemu-devel] [PATCH v3 resend/cleanup 3/8] rdma: introduce ram_handle_compressed(), mrhines, 2013/07/12
- [Qemu-devel] [PATCH v3 resend/cleanup 6/8] rdma: allow state transitions between other states besides ACTIVE, mrhines, 2013/07/12
- [Qemu-devel] [PATCH v3 resend/cleanup 1/8] rdma: update documentation to reflect new unpin support, mrhines, 2013/07/12
[Qemu-devel] [PATCH v3 resend/cleanup 8/8] rdma: account for the time spent in MIG_STATE_SETUP through QMP, mrhines, 2013/07/12
[Qemu-devel] [PATCH v3 resend/cleanup 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, mrhines, 2013/07/12