On 07/12/2013 11:26 AM, Michael R. Hines wrote:
On 07/12/2013 01:09 PM, Eric Blake wrote:
On 07/12/2013 08:40 AM, address@hidden wrote:
From: "Michael R. Hines" <address@hidden>
As requested, the protocol now includes memory unpinning support.
This has been implemented in a non-optimized manner, in such a way
that one could devise an LRU or other workload-specific information
on top of the basic mechanism to influence the way unpinning happens
during runtime.
++++++++++++++++++++++++++++++---------------------
1 file changed, 30 insertions(+), 21 deletions(-)
I suggest splitting this patch into two; and cc-ing the first of the two
patches through qemu-trivial (since formatting cleanups can be applied
now, even while still waiting for a comprehensive review of the
algorithm in the rest of the series)
My understanding is that the reviews have completed already,
including a very extensive test series that I performed which
included both virt-test results and non-virt-test results from both
myself and Chegu.
Am I mistaken?
It may have been reviewed and tested, but as you just barely posted v3
today and there is not yet a maintainer's queue with a PULL request, it
is still subject to any further review that people want to provide, and
up to the maintainer to state definitively if the further review
comments must be addressed. It's not the end of the world if you don't
split this patch, but at the same time, splitting it makes it easier to
review, and to pick and choose which parts get backported (trivial
formatting vs. new feature).