[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on c
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert |
Date: |
Wed, 17 Jul 2013 12:22:42 +0200 |
Am 17.07.2013 um 10:46 schrieb Kevin Wolf <address@hidden>:
> Am 15.07.2013 um 12:49 hat Peter Lieven geschrieben:
>> if a destination has has_zero_init = 0, but it supports
>> discard zeroes use discard to convert the target
>> into an all zero device.
>>
>> Signed-off-by: Peter Lieven <address@hidden>
>
> Wouldn't it be better to use bdrv_write_zeroes() and extend the
> implementation of that to use discard internally in those block drivers
> where it makes sense?
>
> Because here you're not really discarding (i.e. don't care about the
> sectors any more), but you want them to be zeroed.
It is just a fall back in case we can't decide if has_zero_init is 1 easily.
This general approach has the benefit that it is also good for any host device
that has discard zeroes.
Peter
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, (continued)
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, ronnie sahlberg, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, ronnie sahlberg, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Kevin Wolf, 2013/07/18
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, ronnie sahlberg, 2013/07/17
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert, Kevin Wolf, 2013/07/18
- Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert,
Peter Lieven <=
Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/16
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert, Peter Lieven, 2013/07/17