Re: [Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO

[Peter Lieven]

We should change this when bdi->discard_zeroes is available.

Peter

Am 16.07.2013 um 18:29 schrieb Paolo Bonzini <address@hidden>:

> Alternatively, this could use a "discard zeroes data" flag returned
> by bdrv_get_info.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/block.c b/block.c
> index 7ff0716..0c867b8 100644
> --- a/block.c
> +++ b/block.c
> @@ -2977,6 +2977,7 @@ static int64_t coroutine_fn 
> bdrv_co_get_block_status(BlockDriverState *bs,
>                                                      int nb_sectors, int 
> *pnum)
> {
>     int64_t n;
> +    int64_t ret;
> 
>     if (sector_num >= bs->total_sectors) {
>         *pnum = 0;
> @@ -2993,7 +2994,12 @@ static int64_t coroutine_fn 
> bdrv_co_get_block_status(BlockDriverState *bs,
>         return BDRV_BLOCK_DATA;
>     }
> 
> -    return bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, 
> pnum);
> +    ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, 
> pnum);
> +    if (!(ret & BDRV_BLOCK_DATA) && bdrv_has_zero_init(bs)) {
> +        ret |= BDRV_BLOCK_ZERO;
> +    }
> +
> +    return ret;
> }
> 
> /* Coroutine wrapper for bdrv_get_block_status() */
> -- 
> 1.8.3.1
> 
>