Re: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions

[Kwok Cheung Yeung]

On 19/07/2013 3:52 PM, Peter Maydell wrote:
> On 19 July 2013 15:47, Kwok Cheung Yeung <address@hidden> wrote:
> > Decode trap instructions during the handling of an EXCP_TRAP according to
> > the current ISA mode.
> >
> > Signed-off-by: Kwok Cheung Yeung <address@hidden>
> > ---
> >   linux-user/main.c | 20 ++++++++++++++++++--
> >   1 file changed, 18 insertions(+), 2 deletions(-)
> >
> > v2: Read microMIPS instructions sequentially as 16-bit values to avoid
> >      endianess issues. Add braces to if statement to conform to formatting
> >      standards.
>
> This code looks OK but last time round I asked about
> EXCP_BREAK -- why doesn't that also need to change?

This patch was intended to fix the handling of floating-point exceptions while 
running the GCC unit tests (gcc.c-torture/execute/20101011-1.c) on microMIPS, 
which only requires EXCP_TRAP to work properly. I'll post a version with 
EXCP_BREAK fixed shortly.

Thanks

Kwok