[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup. |
Date: |
Fri, 19 Jul 2013 16:11:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/19/2013 03:49 PM, Ian Main wrote:
>>> +++ b/qapi-schema.json
>>> @@ -1807,6 +1807,10 @@
>>> # @format: #optional the format of the new destination, default is to
>>> # probe if @mode is 'existing', else the format of the source
>>> #
>>> +# @sync: what parts of the disk image should be copied to the destination
>>> +# (all the disk, only the sectors allocated in the topmost image, or
>>> +# only new I/O).
>>> +#
>>> # @mode: #optional whether and how QEMU should create a new image, default
>>> is
>>> # 'absolute-paths'.
>>> #
>>
>> This hunk is still wrong. And we still haven't answered the
>> meta-question on whether @format should be mandatory (which I'd rather
>> fix that first, then rebase this on top of that).
>
> How is it wrong when it cleanly applies? You want it separated into
> another patch?
It cleanly applied to the wrong place (drive-mirror), no thanks to git's
automatic fuzzing. It is _no longer necessary_ - DriveBackup already
has this information. I want it dropped completely.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V5 3/4] Add backing drive while performing backup., Ian Main, 2013/07/19
[Qemu-devel] [PATCH V5 4/4] Change default to qcow2 for sync mode none., Ian Main, 2013/07/19