Re: [Qemu-devel] [RFC 6/8] timer: run timers on aio_poll

[Alex Bligh]

Liu,

--On 23 July 2013 10:56:42 +0800 liu ping fan <address@hidden> wrote:

> > I am told (by Stefan H) this approach is unsafe as existing timers may
> > not expect to be run within aio_poll.
> Have not figure out the reason, could you elaborate ?

I asked Stefan H whether we could guarantee that it was safe to
call any timer routine within aio_poll. He said no, because they
might (reasonably) assume they were only being called from the
main loop. Therefore we'd have to audit any existing user. I suppose
an example of something unsafe might be calling aio_poll from inside
a timer routine.

Stefan thus recommended using a separate QEMUClock, and only running
that clock's timers.

--
Alex Bligh