qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return addr


From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument
Date: Tue, 27 Aug 2013 00:26:00 +0100

On 26 August 2013 22:00, Richard Henderson <address@hidden> wrote:
> Allow the code that tcg generates to be less obtuse, passing in
> the return address directly instead of computing it in the helper.

> +uint8_t helper_ret_ldb_mmu(CPUArchState *env, target_ulong addr,
> +                           int mmu_idx, uintptr_t retaddr);

>  uint8_t helper_ldb_mmu(CPUArchState *env, target_ulong addr, int mmu_idx);

I thought the reason we did it this way round was to avoid having
so many arguments to helpers that we overflowed registers and
into the stack on some calling conventions? Or does this not make
much difference in practice?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]