[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST |
|
Date: |
Thu, 29 Aug 2013 16:50:43 +0100 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Thu, Aug 29, 2013 at 08:21:37AM -0700, Richard Henderson wrote:
> Indeed, remove it entirely and remove the is_tcg_gen_code check
> from GETPC_EXT.
>
> Fixes https://bugs.launchpad.net/qemu/+bug/1218098 wherein a call
> to a "normal" helper function performed a sequence of tail calls
> all the way into the memory helper functions, leading to a stack
> frame in which the memory helper function appeared to be called
> directly from tcg.
>
> Signed-off-by: Richard Henderson <address@hidden>
This fixes the bug I saw.
Tested-by: Richard W.M. Jones <address@hidden>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
- Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, (continued)
Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument, Peter Maydell, 2013/08/26
[Qemu-devel] [PULL 6/7] tcg: Tidy softmmu_template.h, Richard Henderson, 2013/08/26
[Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers, Richard Henderson, 2013/08/26
Re: [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization, Aurelien Jarno, 2013/08/27