qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events
Date: Thu, 29 Aug 2013 17:42:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 29/08/2013 17:35, Laszlo Ersek ha scritto:
> On 08/29/13 16:53, Paolo Bonzini wrote:
>> I'll try to salvage the patch.
> 
> I won't bother next time. I wouldn't want you to waste your time on
> "salvaging" the clearly broken patches that I submit.

WTF?

The patch is clearly a good thing, or I wouldn't have asked you to send it.

However, if you don't have time to follow up on my comments, all that a
maintainer can do is:

(1) ignore it and/or let it rot

(2) pick it up and gain something from a patch that isn't quite ready.

#2 is exactly the definition of salvage.

> To be clear, I considered this series a favor.

Sure, and it's very welcome.  But you shouldn't expect too much from
your interlocutor after writing "I don't have any more time for this".

If you don't have any more time for this, next time send me the patch
privately and say it in advance before I even start reviewing it.  I'll
make sure you're properly acknowledged with From and Signed-off-by headers.

Paolo, glad that this time he's on the receiving edge of a flame...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]