Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes & cleanup

[Markus Armbruster]

Stefan Weil <address@hidden> writes:

> Am 31.07.2013 15:11, schrieb Markus Armbruster:
>> All I wanted to do is exit(1) instead of abort() on guest memory
>> allocation failure [07/08].  But that lead me into a minor #ifdef bog,
>> and here's what I brought back.  Enjoy!
>>
>> Testing:
>> * Christian Borntraeger reports v1 works fine under LPAR (new S390
>>   KVM, i.e. generic allocation) and as second guest under z/VM (old
>>   S390 KVM, i.e. legacy S390 allocation).  Thanks for testing, and for
>>   catching a stupid mistake.  v2 differs from v1 only in code that
>>   isn't reachable on S390.
[...]
> Two patches from this series seem to cause compiler errors
> in latest QEMU ona 32 bit Ubuntu precise host:
>
>   CC    arm-softmmu/exec.o
> exec.c:752:51: error: initialization from incompatible pointer type
> [-Werror]
> exec.c: In function 'qemu_ram_alloc_from_ptr':
> exec.c:1139:32: error: comparison of distinct pointer types lacks a cast
> [-Werror]
> exec.c: In function 'qemu_ram_remap':
> exec.c:1283:21: error: comparison of distinct pointer types lacks a cast
> [-Werror]
>
> There is a mismatch of function prototypes (size_t <-> ram_addr_t):
>
> void *qemu_anon_ram_alloc(size_t size);
> static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc;
>
> It's strange that the buildbots don't complain.

Indeed.  Thanks for posting a fix!