[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs |
Date: |
Mon, 30 Sep 2013 17:55:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
Am 30.09.2013 17:50, schrieb Michael S. Tsirkin:
> On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote:
>> On 30 September 2013 23:40, Michael S. Tsirkin <address@hidden> wrote:
>>> diff --git a/include/qapi/error.h b/include/qapi/error.h
>>> index 7d4c696..b85e996 100644
>>> --- a/include/qapi/error.h
>>> +++ b/include/qapi/error.h
>>> @@ -13,14 +13,15 @@
>>> #define ERROR_H
>>>
>>> #include "qemu/compiler.h"
>>> +#include "qemu/typedefs.h"
>>> #include "qapi-types.h"
>>> #include <stdbool.h>
>>>
>>> /**
>>> - * A class representing internal errors within QEMU. An error has a
>>> ErrorClass
>>> + * Error:
>>> + * An object representing internal errors within QEMU. An error has a
>>> ErrorClass
>>> * code and a human message.
>>> */
>>> -typedef struct Error Error;
>>
>> Does the process-doc-comments tool really cope with documentation comments
>> that are completely separate from the typedef like this?
>>
>> thanks
>> -- PMM
>
> Do we care?
> Downstreams don't seem to package it, most people probably use
> editor tags anyway ...
> If yes we can put this all in #if 0.
Can we turn the typedef into just struct Error here? The doc comment can
be applied to either.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v6 03/26] qom: cleanup struct Error references, (continued)
- [Qemu-devel] [PATCH v6 03/26] qom: cleanup struct Error references, Michael S. Tsirkin, 2013/09/29
- [Qemu-devel] [PATCH v6 04/26] qom: add pointer to int property helpers, Michael S. Tsirkin, 2013/09/29
- [Qemu-devel] [PATCH v6 02/26] qom: pull in qemu/typedefs, Michael S. Tsirkin, 2013/09/29
- [Qemu-devel] [PATCH v6 05/26] fw_cfg: interface to trigger callback on read, Michael S. Tsirkin, 2013/09/29
- [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/29
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Igor Mammedov, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Igor Mammedov, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Peter Maydell, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Markus Armbruster, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Markus Armbruster, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Markus Armbruster, 2013/09/30
[Qemu-devel] [PATCH v6 06/26] loader: support for unmapped ROM blobs, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 07/26] pcie_host: expose UNMAPPED macro, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 08/26] pcie_host: expose address format, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 09/26] q35: use macro for MCFG property name, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 10/26] q35: expose mmcfg size as a property, Michael S. Tsirkin, 2013/09/29