[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.1
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14 |
|
Date: |
Thu, 21 Nov 2013 15:16:46 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 21/11/2013 15:16, Michael S. Tsirkin ha scritto:
> > This looks good, but is the below part necessary? It's ugly!
>
> Unfortunately yes. With old glib we don't know element size
> so we have to make all elements same size (1 byte).
>
> Without making change below change above will trigger assertions.
Ok, then please mention it in the commit message.
Reviewed-by: Paolo Bonzini <address@hidden>
Paolo