qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDri


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState
Date: Tue, 26 Nov 2013 18:31:58 +0800

On Tue, Nov 26, 2013 at 6:25 PM, Paolo Bonzini <address@hidden> wrote:
> Il 26/11/2013 11:19, Fam Zheng ha scritto:
>>> So that you can add the same Error to multiple items of the array with a
>>> single bdrv_op_block call (by ORing them into the second parameter).
>>
>> What data type to contain this? I'm not sure 64 is enough in long term...
>
> I would just use an uint64_t, I think you have ~20 operations now.
> There is still quite some breathing room.
>
OK. Then, can we still use QAPI enum? Because I think being possible
to query blockers makes sense, that way the user doesn't have to trial
and error to know what operation is blocked.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]