Re: [Qemu-devel] [PATCH arm-devs v1 11/13] net/cadence_gem: Fix register w1c logic

[Peter Maydell]

On 2 December 2013 07:15, Peter Crosthwaite
<address@hidden> wrote:
> This write-1-clear logic was incorrect. It was always clearing w1c
> bits regardless of whether thie written value was 1 or not. i.e. it
> was implementing a write-anything-to-clear strategy.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

Looks correct now, though it is not the most translucent piece
of logic I've ever read :-)

thanks
-- PMM