qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"
Date: Sat, 14 Dec 2013 00:59:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 13.12.2013 22:00, Eric Blake wrote:
On 12/13/2013 01:49 PM, Kevin Wolf wrote:
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
Introduce an alias "error" for "errno", since using the latter for QMP
is sure to result in various syntax errors due to the name being used
directly as an identifier.

Signed-off-by: Max Reitz <address@hidden>
I can't say I like this, but it seems we don't have an option.
Don't we already have a way to use QMP keys that collide with C keywords
(for example, "unix" in qapi's SocketAddress becomes "q_unix" in C)?
Why can't we reuse that mechanism, and just add "errno" to the polluted
words list so that the generated C code uses "q_errno" rather than
having to invent an "error" alias?

Great, I'll have a look.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]