Re: [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode

[Stefan Hajnoczi]

On Thu, Dec 19, 2013 at 10:27:36AM +0800, Hu Tao wrote:
> diff --git a/include/block/block.h b/include/block/block.h
> index 36efaea..3732f25 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -527,4 +527,10 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs, 
> const char *tag);
>  int bdrv_debug_resume(BlockDriverState *bs, const char *tag);
>  bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag);
>  
> +enum prealloc_mode {

Please follow modern QEMU coding style and use CamelCase: PreallocMode

It would be nice to use PreallocMode instead int for variables.