Re: [Qemu-devel] [PATCH 0/4] disas: add libvixl to support A64 disassembly

[Peter Maydell]

On 8 January 2014 06:55, Stefan Weil <address@hidden> wrote:
> Am 08.01.2014 00:00, schrieb Peter Maydell:
>> Some experimentation suggests it would also be possible to
>> just do
>>
>> extern "C" {
>> #include "disas/bfd.h"
>> }
>>
>> in the C++ file. If that doesn't have any hidden gotchas I don't
>> know about it looks like the nicest solution.
>>
>
> Adding the extern "C" to include/disas/bfd.h would be even better. It
> might be possible to use the glib macros G_BEGIN_DECLS and G_END_DECLSor
> __BEGIN_DECLS and __END_DECLS from the C library for this purpose.

Depends on your point of view. I'd rather keep the C++ in the C++
files, and have QEMU's general header files be C. After all,
every prototype in that header should have C linkage: it's
the definition of print_insn_aarch64() that's the odd one out, not
its declaration.

-- PMM