[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus |
Date: |
Wed, 08 Jan 2014 15:07:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 08/01/2014 14:53, Andreas Färber ha scritto:
> Am 08.01.2014 12:02, schrieb Paolo Bonzini:
>> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
>>>>> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus,
>>>>> 2013-06-18). Should probably be reverted.
>>>>>
>>> Prefer not, under no reasonable definition is NAND a sysbus device.
>>> Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to
>>> qtree that TYPE_DEVICE is not?
>>
>> The device's dev->parent_bus is main_system_bus.
>
> Meaning in turn that qdev_create() was used rather then object_new().
> Simple fix. :)
Happy as usual to be shown wrong! :)
> Possibly already in my pending qom-next pull?
No, unfortunately not.
Paolo
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, (continued)
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Markus Armbruster, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Peter Maydell, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Markus Armbruster, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Peter Crosthwaite, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Andreas Färber, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Paolo Bonzini, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Peter Crosthwaite, 2014/01/10
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Markus Armbruster, 2014/01/10
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Paolo Bonzini, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus, Andreas Färber, 2014/01/08
- Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus,
Paolo Bonzini <=