qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 16/76] target-arm: Widen thread-local register st


From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 16/76] target-arm: Widen thread-local register state fields to 64 bits
Date: Wed, 8 Jan 2014 18:32:25 +0000

On 7 January 2014 20:03, Peter Maydell <address@hidden> wrote:
> +#ifdef HOST_WORDS_BIGENDIAN
> +#define offsetoflow32(S, M) (offsetof(S, M + sizeof(uint32_t))

Mismatched brackets, won't build on bigendian hosts.
(I happened to randomly run cppcheck, or I'd not have spotted
that.)

Reroll #2 coming up later, though I'll just send the cover letter...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]