[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block: remove unnecessary code; image always r/w if snapshot=on |
Date: |
Tue, 21 Jan 2014 17:30:52 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 21.01.2014 um 17:17 hat Eric Blake geschrieben:
> On 01/21/2014 09:14 AM, Jeff Cody wrote:
> > Important note: this patch should only be applied after patch
> > "block: do not allow read-only=on and snapshot=on to be used together"
> >
> > Now that 'read-only=on' and 'snapshot=on' are not allowed together,
> > forcing open_flags to have BDRV_O_RDWR set is redundant code, and can be
> > removed. This is because unless read-only=on is specified, the image
> > will always be opened with BDRV_O_RDWR set.
> >
> > Signed-off-by: Jeff Cody <address@hidden>
> > ---
> > block.c | 7 -------
> > 1 file changed, 7 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks, applied to the block branch.
Kevin
pgp3Ho8BL3B4x.pgp
Description: PGP signature