[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] target-arm: Add support for AArch32 FP VRIN
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] target-arm: Add support for AArch32 FP VRINTR |
Date: |
Mon, 27 Jan 2014 16:35:38 +0000 |
On 14 January 2014 16:43, Will Newton <address@hidden> wrote:
> Add support for the AArch32 floating-point VRINTR instruction.
>
> Signed-off-by: Will Newton <address@hidden>
> ---
> target-arm/translate.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index f688f6d..73e0e8d 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -3374,6 +3374,17 @@ static int disas_vfp_insn(CPUARMState * env,
> DisasContext *s, uint32_t insn)
> gen_vfp_F1_ld0(dp);
> gen_vfp_cmpe(dp);
> break;
> + case 12: /* vrintr */
> + if (dp) {
> + TCGv_ptr fpst = get_fpstatus_ptr(0);
> + gen_helper_rintd(cpu_F0d, cpu_F0d, fpst);
> + tcg_temp_free_ptr(fpst);
> + } else {
> + TCGv_ptr fpst = get_fpstatus_ptr(0);
> + gen_helper_rints(cpu_F0s, cpu_F0s, fpst);
> + tcg_temp_free_ptr(fpst);
> + }
Please pull the common setup/teardown of fpst out of the
two branches of this if():
case 12: /* vrintr */
{
TCGv_ptr fpst = ...
if (dp) {
gen_helper_rintd(..)
} else {
gen_helper_rints(..)
}
tcg_temp_free...
break;
}
and similarly for other patches in this series (especially
where we're also doing setup/teardown of rounding mode).
thanks
-- PMM
- [Qemu-devel] [PATCH 0/9] target-arm: Add AArch32 ARMv8 VRINT instructions, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 1/9] target-arm: Move arm_rmode_to_sf to a shared location., Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 3/9] target-arm: Add support for AArch32 FP VRINTR, Will Newton, 2014/01/14
- Re: [Qemu-devel] [PATCH 3/9] target-arm: Add support for AArch32 FP VRINTR,
Peter Maydell <=
- [Qemu-devel] [PATCH 4/9] target-arm: Add support for AArch32 FP VRINTZ, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 6/9] target-arm: Add support for AArch32 SIMD VRINTX, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 5/9] target-arm: Add support for AArch32 FP VRINTX, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 2/9] target-arm: Add AArch32 FP VRINTA, VRINTN, VRINTP and VRINTM, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 7/9] target-arm: Add set_neon_rmode helper, Will Newton, 2014/01/14
- [Qemu-devel] [PATCH 8/9] target-arm: Add support for AArch32 SIMD VRINTZ, Will Newton, 2014/01/14